"Visa fler" budget counts every thread ever opened #235

New issue

Closed

opened 2026-10-21 19:17:26 +00:00 by littlefox · 1 comment

littlefox commented

2026-10-21 19:17:26 +00:00

Owner

Found while looking into scrolling (#230, D-058). This bug came with #223 (#220).

opened in app/src/main_view/mod.rs holds every post whose "Visa fler" was clicked. It is never cleared: the comment says texts of other threads in it don't matter. They do. Kom::thread gives an opened branch a budget of OPEN_BUDGET * open.len(), counting all opened posts, including other threads'.

So after "Visa fler" in 20 threads, the next click anywhere opens up to 2 000 posts instead of 100. The set is also cloned on every thread load, and grows for the whole session.

Fix:

count only the opened posts that are in this thread, or keep opened per thread root and drop it when the thread is left;
add a test in thread_tree with an opened post from another thread.

Found while looking into scrolling (#230, D-058). This bug came with #223 (#220). `opened` in `app/src/main_view/mod.rs` holds every post whose "Visa fler" was clicked. It is **never cleared**: the comment says texts of other threads in it don't matter. They do. `Kom::thread` gives an opened branch a budget of `OPEN_BUDGET * open.len()`, counting *all* opened posts, including other threads'. So after "Visa fler" in 20 threads, the next click anywhere opens up to 2 000 posts instead of 100. The set is also cloned on every thread load, and grows for the whole session. Fix: - count only the opened posts that are in this thread, or keep `opened` per thread root and drop it when the thread is left; - add a test in `thread_tree` with an opened post from another thread.

littlefox added this to the 0.6: Performance milestone

2026-10-21 19:17:26 +00:00

littlefox added the

area/reading

kind/bug

labels

2026-10-21 19:17:26 +00:00

littlefox referenced this issue

2026-10-21 19:17:36 +00:00

Long lists like Discord: draw only what is near, cache some, refetch the rest #236

littlefox referenced this issue

2026-10-21 19:17:37 +00:00

Memory grows without bound in big meetings (close to 1 GiB) #227

littlefox referenced this issue from a commit

2026-10-21 21:15:37 +00:00

Count only this thread's opened posts in the "Visa fler" budget

littlefox referenced this issue from a pull request that will close it,

2026-10-21 21:16:21 +00:00

"Visa fler": count only this thread's opened posts #248

littlefox closed this issue

2026-10-21 22:27:42 +00:00

littlefox commented

2026-10-21 23:01:32 +00:00

Author

Owner

Merged in #248; main run #403 green. Verified: the devserver test thread_tree opens a 110-link chain at its root with and without posts opened elsewhere and expects the same; it failed before the fix and passes after. thread.spec and show-more.spec pass in CI.

Merged in #248; main run #403 green. Verified: the devserver test `thread_tree` opens a 110-link chain at its root with and without posts opened elsewhere and expects the same; it failed before the fix and passes after. thread.spec and show-more.spec pass in CI.