Service worker keeps every old build forever #241

New issue

Closed

opened 2026-10-21 19:22:22 +00:00 by littlefox · 1 comment

littlefox commented

2026-10-21 19:22:22 +00:00

Owner

Found in the performance review (#230, D-058).

app/public/sw.js stores every hashed build file (wasm, js, css) in the cache neokom-shell-v1 the first time it is fetched, and never removes old ones. The cache name doesn't change between versions, so activate doesn't clean them either.

Every release, and every rebuild on the home container, adds another ~4.5 MB of wasm (#231) to the browser's storage on each device. With Kubernetes autorolling each release, phones collect old versions until the browser evicts the site for quota.

Fix:

On activate (or after the page has loaded), delete the cached assets/ entries that the current index.html doesn't reference.
Or include the build hash in the cache name, so activate's existing cleanup drops old ones.
Add an e2e check: load, "deploy" a new build, load again; the cache holds one wasm.

Found in the performance review (#230, D-058). `app/public/sw.js` stores every hashed build file (wasm, js, css) in the cache `neokom-shell-v1` the first time it is fetched, and **never removes old ones**. The cache name doesn't change between versions, so `activate` doesn't clean them either. Every release, and every rebuild on the home container, adds another ~4.5 MB of wasm (#231) to the browser's storage on each device. With Kubernetes autorolling each release, phones collect old versions until the browser evicts the site for quota. Fix: - On `activate` (or after the page has loaded), delete the cached `assets/` entries that the current `index.html` doesn't reference. - Or include the build hash in the cache name, so `activate`'s existing cleanup drops old ones. - Add an e2e check: load, "deploy" a new build, load again; the cache holds one wasm.

littlefox added this to the 0.6: Performance milestone

2026-10-21 19:22:22 +00:00

littlefox added the

area/web

kind/bug

labels

2026-10-21 19:22:22 +00:00

littlefox referenced this issue from a pull request that will close it,

2026-10-22 00:14:53 +00:00

Service worker: keep one version of each build file #258

littlefox referenced this issue from a commit

2026-10-22 00:14:53 +00:00

Service worker: keep one version of each build file

littlefox closed this issue

2026-10-22 00:53:19 +00:00

littlefox commented

2026-10-22 01:50:35 +00:00

Author

Owner

Merged in #258; main run #426 green. Verified: the new PWA test plants an older wasm in the cache and checks only the current one is kept after a reload; it failed without the change. Desktop and Android (WebKit skips service workers on http loopback).