Flaky: thread.spec "deep thread" on iPhone, a card read by being seen #249

Closed
opened 2026-10-21 21:57:23 +00:00 by littlefox · 2 comments
Owner

CI run #400 (PR #248), and earlier in a local full run: thread.spec.ts "a deep thread: indentation stops, cards say whom they answer" fails on iPhone. After the checks of indentation, space shows "Kommentar på djup 2." instead of "… djup 1.".

Cause: the test looks at the thread for several seconds, and the card for depth 1 is on screen long enough to be read by being seen (#180), so the engine skips it. The first test in the file sets window.__neokomSeenOff for this reason; this one doesn't.

Fix: set it here too.

CI run #400 (PR #248), and earlier in a local full run: `thread.spec.ts` "a deep thread: indentation stops, cards say whom they answer" fails on iPhone. After the checks of indentation, space shows "Kommentar på djup 2." instead of "… djup 1.". Cause: the test looks at the thread for several seconds, and the card for depth 1 is on screen long enough to be read by being seen (#180), so the engine skips it. The first test in the file sets `window.__neokomSeenOff` for this reason; this one doesn't. Fix: set it here too.
Author
Owner

Also in run #400: time.spec.ts on Android (passed on retry). The tap on the time didn't switch it to the exact time. The post had just been shown, and it is drawn again when its thread arrives around it, so the tapped label was replaced and its state went with it. The spec now taps until it takes; the re-drawing itself is #229.

Also in run #400: `time.spec.ts` on Android (passed on retry). The tap on the time didn't switch it to the exact time. The post had just been shown, and it is drawn again when its thread arrives around it, so the tapped label was replaced and its state went with it. The spec now taps until it takes; the re-drawing itself is #229.
Author
Owner

Fixed in #248 (main #403 green): thread.spec's deep-thread test turns read-by-seen off; time.spec taps until the label switches. Both passed on all three profiles locally and in CI.

Fixed in #248 (main #403 green): thread.spec's deep-thread test turns read-by-seen off; time.spec taps until the label switches. Both passed on all three profiles locally and in CI.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
littlefox/neokom#249
No description provided.