Flaky: thread.spec "deep thread" on iPhone, a card read by being seen #249
Labels
No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
littlefox/neokom#249
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CI run #400 (PR #248), and earlier in a local full run:
thread.spec.ts"a deep thread: indentation stops, cards say whom they answer" fails on iPhone. After the checks of indentation, space shows "Kommentar på djup 2." instead of "… djup 1.".Cause: the test looks at the thread for several seconds, and the card for depth 1 is on screen long enough to be read by being seen (#180), so the engine skips it. The first test in the file sets
window.__neokomSeenOfffor this reason; this one doesn't.Fix: set it here too.
Also in run #400:
time.spec.tson Android (passed on retry). The tap on the time didn't switch it to the exact time. The post had just been shown, and it is drawn again when its thread arrives around it, so the tapped label was replaced and its state went with it. The spec now taps until it takes; the re-drawing itself is #229.Fixed in #248 (main #403 green): thread.spec's deep-thread test turns read-by-seen off; time.spec taps until the label switches. Both passed on all three profiles locally and in CI.