Read by being seen without reloading the thread; redraw only what changed #254

Merged

littlefox merged 5 commits from issue-228-quiet-marks into main 2026-10-22 00:53:34 +00:00

Conversation 0 Commits 5 Files changed 9 +179 -62

littlefox commented 2026-10-21 23:11:07 +00:00

Owner

Copy link

Closes #228
Closes #226
Closes #256

• The thread loader follows its own epoch signal (text actions), not tick: a post read by being seen no longer reloads and redraws the thread. Logins and logouts bump presence::CHANGES, not changes.
• Cards seen within 300 ms are marked together: Kom::mark_read_many, one mark-as-read per channel.
• SEEN_JS is event-driven (scroll, page changes, resize, tab back; once a frame at most, a timer only while a card waits out its second) instead of reading every card's layout every 250 ms.
• Cards hold thread_view::Shared (an Rc<TextView> compared by pointer); previews go in 8 at a time or every 150 ms; the mention/search indexer no longer deep-copies every card on each preview; the thread and channel panes don't follow the 30 s clock.

Measured with tools/perf.sh (#225; this branch has #252 merged in for that), reading 120 cards by scrolling slowly past them:

	baseline	after
server calls	287	99 (−66 %)
layouts	119	35 (−71 %)
style recalcs	126	61 (−52 %)
main-thread busy	1.2 s	0.37 s (−69 %)

Reading 300 posts along the chain: style recalcs 2 358 → 1 578 (−33 %). Idle main-thread time 0.03 → 0.01 s per 20 s. Everything else unchanged within noise.

Also #256: soak.spec read the previous post's status line; it now waits for a new number (soak passes locally, 32 posts, 16 drops).

Verified: full e2e suite on desktop, Android and iPhone, 327 passed; lint three ways.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #228 Closes #226 Closes #256 - The thread loader follows its own `epoch` signal (text actions), not `tick`: a post read by being seen no longer reloads and redraws the thread. Logins and logouts bump `presence::CHANGES`, not `changes`. - Cards seen within 300 ms are marked together: `Kom::mark_read_many`, one `mark-as-read` per channel. - `SEEN_JS` is event-driven (scroll, page changes, resize, tab back; once a frame at most, a timer only while a card waits out its second) instead of reading every card's layout every 250 ms. - Cards hold `thread_view::Shared` (an `Rc<TextView>` compared by pointer); previews go in 8 at a time or every 150 ms; the mention/search indexer no longer deep-copies every card on each preview; the thread and channel panes don't follow the 30 s clock. Measured with `tools/perf.sh` (#225; this branch has #252 merged in for that), reading 120 cards by scrolling slowly past them: | | baseline | after | |---|---|---| | server calls | 287 | 99 (−66 %) | | layouts | 119 | 35 (−71 %) | | style recalcs | 126 | 61 (−52 %) | | main-thread busy | 1.2 s | 0.37 s (−69 %) | Reading 300 posts along the chain: style recalcs 2 358 → 1 578 (−33 %). Idle main-thread time 0.03 → 0.01 s per 20 s. Everything else unchanged within noise. Also #256: soak.spec read the previous post's status line; it now waits for a new number (soak passes locally, 32 posts, 16 drops). Verified: full e2e suite on desktop, Android and iPhone, 327 passed; lint three ways. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

littlefox added 5 commits 2026-10-21 23:11:07 +00:00

Measure first: a big meeting, a perf spec and a desktop memory run ... c5abe1fe63

0.6 is about performance (D-057), and every fix should come with a
before/after number. tools/perf.sh seeds a big meeting (NEOKOM_SEED_PERF:
~2 800 texts, a 1 500-long chain, 300 more channels, 2 500 letters) on a
lyskomd kept in memory, puts 30 ms each way between relay and server,
and runs e2e/perf/perf.spec.ts in Chromium: memory (JS heap and the
app's wasm), DOM nodes, main-thread time, long tasks, frames while
scrolling, step times and server calls. tools/desktop-perf.sh measures
the desktop app's RSS and idle CPU. tools/perf-table.py compares runs.

The app exposes its wasm memory and the session's call count to the page
for this; Chromium shows no WebSocket frames sent from wasm.

Refs #225

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Read by being seen without reloading the thread; redraw only what changed ... 3c2a090eca

Every card read by being seen bumped the signal the thread loader follows,
so each one reloaded the thread and redrew every card, and so did every
login or logout on the server. Now:
- the thread loader follows its own signal, bumped by text actions, not
  by marks; logins and logouts bump presence::CHANGES instead of changes;
- cards seen within 300 ms go to the server together, one mark-as-read
  per channel (Kom::mark_read_many), and the counts change once;
- the seen check runs on scroll and page changes, at most once a frame,
  instead of reading every card's layout four times a second;
- cards hold their post as a Shared view compared by pointer, previews go
  in a few at a time, the mention/search indexer no longer deep-copies
  every card, and the panes don't redraw for the 30 s clock.

Closes #228
Closes #226

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Merge remote-tracking branch 'origin/issue-225-measure' into issue-228-quiet-marks 8da5e2c74c

Perf: a scenario for reading cards by scrolling past them ... 91bc19544c

Reading with space marks few cards by being seen, the case #228 is
about. This scrolls slowly through a post's 120 unread replies.

Refs #225

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Merge remote-tracking branch 'origin/issue-225-measure' into issue-228-quiet-marks 36977eae75

littlefox referenced this pull request 2026-10-21 23:48:23 +00:00

Flaky: soak.spec matches the previous post's status line #256

littlefox added 2 commits 2026-10-22 00:09:48 +00:00

Soak spec: wait for a new post number, not any ... 3aa1c749af

The previous post's status line matched until the new one replaced it,
so the check read the old number and failed.

Refs #256

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Merge remote-tracking branch 'origin/main' into issue-228-quiet-marks 3a124bc112

littlefox merged commit fc06315278 into main 2026-10-22 00:53:34 +00:00

littlefox referenced this pull request from a commit 2026-10-22 00:53:34 +00:00

Merge pull request 'Read by being seen without reloading the thread; redraw only what changed' (#254) from issue-228-quiet-marks into main

littlefox referenced this pull request 2026-10-22 01:50:33 +00:00

Reading view redraws everything, and every post read reloads the whole thread #226

littlefox referenced this pull request 2026-10-22 01:50:34 +00:00

Jittery scrolling through unread posts #228

littlefox referenced this pull request 2026-10-22 01:50:34 +00:00

Flaky: soak.spec matches the previous post's status line #256

littlefox referenced this pull request 2026-10-22 02:01:20 +00:00

Fewer round trips: light previews, cached names, cards a few at a time #261

littlefox referenced this pull request 2026-10-22 02:27:31 +00:00

Channel list at login: counts six at a time, read ranges in one call #262

littlefox referenced this pull request from a commit 2026-10-22 02:34:26 +00:00

Merge origin/main; thread cards and inbox previews a few at a time

littlefox referenced this pull request 2026-10-22 04:04:13 +00:00

Fewer server round trips when showing posts and threads #234

littlefox referenced this pull request 2026-10-22 04:04:14 +00:00

Inbox reads the stat of every text in the mailbox, again on every login anywhere #237

littlefox referenced this pull request 2026-10-22 06:47:31 +00:00

Presence dots: redrawn only when what they show changes #271

littlefox referenced this pull request from a commit 2026-10-22 07:17:21 +00:00

Presence dots: redrawn only when what they show changes

littlefox referenced this pull request 2026-10-22 14:11:05 +00:00

Release 0.6.0 #281

littlefox referenced this pull request from a commit 2026-10-22 14:11:05 +00:00

Release 0.6.0

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/ci

Forgejo Actions, runner, tests

  

area/desktop

Desktop build

  

area/packaging

Arch, Debian, Fedora, NixOS packages

  

area/protocol

kom-proto, wire format, charset

  

area/reading

Unread tracking, reading order, review

  

area/ui

Dioxus app, layout, interaction

  

area/web

Web build and relay

  

area/writing

Composing and sending texts

  

kind/bug

Something is broken

  

kind/feature

New functionality

  

kind/infra

Tooling, tests, CI, dev environment

  

kind/request

requests for features or changes from users

  

needs/user

Waiting for a decision or action from littlefox

  

parked

Kept for reference; no work planned until the user says so

  

perf

Run the perf workflow and its budgets on this pull request (#287)

  

security

Security-relevant

  

upstream

A proposal for Protocol A or lyskomd, for the LysKOM development group

No labels

area/ci

area/desktop

area/packaging

area/protocol

area/reading

area/ui

area/web

area/writing

kind/bug

kind/feature

kind/infra

kind/request

needs/user

parked

perf

security

upstream

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

littlefox/neokom!254

No description provided.