Enter and Space can't press a focused button #322

New issue

Closed

opened 2026-10-23 22:39:51 +00:00 by littlefox · 1 comment

littlefox commented

2026-10-23 22:39:51 +00:00

Owner

Fix: when the focused control was reached with the keyboard (:focus-visible), Enter and Space go to it. After a mouse click a button keeps focus, but it isn't focus-visible, so space still reads on as before.

Found while testing #315: the global keys take Enter and Space (the default action, "Läs nästa") even when a button has keyboard focus, so keyboard users can't press "Visa äldre", "Ångra" or any other button with Enter or Space. Fix: when the focused control was reached with the keyboard (`:focus-visible`), Enter and Space go to it. After a mouse click a button keeps focus, but it isn't focus-visible, so space still reads on as before.

littlefox added this to the 0.7: Threads milestone

2026-10-23 22:39:51 +00:00

littlefox added the

kind/bug

label

2026-10-23 22:39:51 +00:00

littlefox referenced this issue from a pull request that will close it,

2026-10-24 02:14:34 +00:00

Mark a channel read from its head, and undo it; Enter on a tabbed-to button #325

littlefox closed this issue

2026-10-24 02:53:24 +00:00

littlefox referenced this issue from a commit

2026-10-24 02:53:25 +00:00

Mark a channel read from its head, and undo it; the head stays on screen

littlefox referenced this issue from a commit

2026-10-24 02:53:25 +00:00

Test: Enter presses the button tabbed to (#322)

littlefox referenced this issue from a commit

2026-10-24 02:53:25 +00:00

Keys: a clicked control gives Space back to reading (#322)

littlefox commented

2026-10-24 03:31:21 +00:00

Author

Owner

Fixed in #325; main green (ci #586).

A control reached with Tab keeps its own Enter and Space. The one last pressed with a pointer gives them back to reading, so Space after a click still reads on. This is tracked from pointerdown: the first try used :focus-visible, and Chromium counts a clicked button as keyboard-focused once any key has been pressed, so Space pressed the button just clicked (charset and settle specs caught it).
keys.spec.ts: Tab to Inkorg, then Enter, opens the inbox and reads nothing. It fails without the fix.
Full suite passes, including charset/settle/reading/commands.

Fixed in #325; main green (ci #586). - A control reached with Tab keeps its own Enter and Space. The one last pressed with a pointer gives them back to reading, so Space after a click still reads on. This is tracked from `pointerdown`: the first try used `:focus-visible`, and Chromium counts a clicked button as keyboard-focused once any key has been pressed, so Space pressed the button just clicked (charset and settle specs caught it). - `keys.spec.ts`: Tab to Inkorg, then Enter, opens the inbox and reads nothing. It fails without the fix. - Full suite passes, including charset/settle/reading/commands.