Images with text are multipart: jskom and the Emacs client can't show them #329
Labels
No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
littlefox/neokom#329
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Reported by the user: their profile picture, uploaded with NeoKOM, shows in jskom as
[unknown content-type: "multipart/mixed;boundary="neokom-9e3769f4""], and the Emacs client can't show it either.Cause: an image with text (a caption, or a presentation's text) is written as
multipart/mixed. jskom renders onlytext/*andimage/*(partials/text.html); the Emacs client says "< Flerdelade inlägg (…) stöds inte. >" (lyskom-format-multipart). Both showimage/*texts (subject line, then the raw image). jskom itself posts an image as the whole text, never with a caption. DESIGN's "as jskom does" was wrong for the captioned case.Decided (D-067): the text is posted as usual, and the image follows as an
image/*footnote by the same author. The Emacs client reads it right after the text; jskom lists it as a footnote; NeoKOM draws footnotes inside the post. An image without text stays one image text. Presentations the same; the avatar is also found in the presentation's footnotes. Old multipart posts stay; NeoKOM keeps reading multipart. The user re-saves their presentation once the fix is out.Fixed in #330; main green (run #606). D-067.
split_image(no multipart written).image/jpeg; a presentation with text and a picture, avatar found in its footnote.Note: Protocol A recommends multipart for this case. Whether to keep D-067 is open in #331.