A settings change is lost when logging out right after leaving settings #124
Labels
No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
littlefox/neokom#124
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found by CI run #201 (main): settings.spec failed on Android and iPhone. Leaving the settings screen saves the last change in the background (about 120 ms locally, longer on a busy machine); logging out right away disconnects first and the save is lost. A real user can do the same: change a setting, go back, log out.
Fix: logging out waits for settings saves under way (at most 10 s). The spec now logs out right after leaving the screen, and waits for the login page before logging in again (it used to reload the page while logging out); without the fix it fails, with it it passes.