Logging out waits for a settings save under way #125

Merged
littlefox merged 1 commit from settings-save-before-logout into main 2026-10-18 19:01:30 +00:00
Owner

Closes #124

Main's CI (#201) failed in settings.spec on Android and iPhone: a change saved in the background on leaving the settings screen was cut off by logging out. Real bug, not just the test.

  • settings_view::SAVING counts saves under way; logout waits for 0 (at most 10 s).
  • settings.spec logs out right after leaving the screen and waits for the login page before logging in again.

Verified: with timestamps in the browser console, the save (~120 ms) ends before the logout starts. The new spec fails without the logout change and passes with it, on desktop, Android and iPhone. Clippy native/wasm/desktop clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #124 Main's CI (#201) failed in settings.spec on Android and iPhone: a change saved in the background on leaving the settings screen was cut off by logging out. Real bug, not just the test. - `settings_view::SAVING` counts saves under way; logout waits for 0 (at most 10 s). - settings.spec logs out right after leaving the screen and waits for the login page before logging in again. Verified: with timestamps in the browser console, the save (~120 ms) ends before the logout starts. The new spec fails without the logout change and passes with it, on desktop, Android and iPhone. Clippy native/wasm/desktop clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Logging out waits for a settings save under way
All checks were successful
ci / check (push) Successful in 8m38s
ci / desktop (push) Successful in 15m24s
ci / e2e (push) Successful in 17m56s
f39042098c
Leaving the settings screen saves the last change in the background;
logging out right after disconnected first and the change was lost (CI
run #201, settings.spec on Android and iPhone). Saves are counted, and
logout waits for them, at most 10 s. The spec logs out at once now and
waits for the login page, as a person would.

Refs #124

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
littlefox referenced this pull request from a commit 2026-10-19 05:23:03 +00:00
Sign in to join this conversation.
No description provided.