Scroll the columns, never the page #218

Merged
littlefox merged 2 commits from issue-215-page-scroll into main 2026-10-21 10:14:24 +00:00
Owner

Closes #215
Closes #216

A post's screen-reader "Ärende:" label is absolutely placed with no positioned ancestor, so far down a scrolled reading column it stretched the page below the window. The wheel past a column's end, or "Läs nästa" scrolling a card into view, then scrolled the whole page and hid the header. Columns are now position: relative and the shell clips.

Verified: new page-scroll.spec reproduces it (page 2497 px taller than the window, scrolled 465 px with the header off screen) and passes after the fix in Chromium and WebKit at desktop size; thread and scroll specs still pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #215 Closes #216 A post's screen-reader "Ärende:" label is absolutely placed with no positioned ancestor, so far down a scrolled reading column it stretched the page below the window. The wheel past a column's end, or "Läs nästa" scrolling a card into view, then scrolled the whole page and hid the header. Columns are now position: relative and the shell clips. Verified: new page-scroll.spec reproduces it (page 2497 px taller than the window, scrolled 465 px with the header off screen) and passes after the fix in Chromium and WebKit at desktop size; thread and scroll specs still pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Scroll the columns, never the page
Some checks failed
ci / check (push) Successful in 7m48s
ci / desktop (push) Successful in 13m56s
ci / e2e (push) Failing after 36m9s
f2c3d78ff9
The screen-reader label in a post's subject is absolutely placed, and
with no positioned ancestor it was placed relative to the page. Far down
a scrolled reading column (the end of a thread) it stretched the page
below the window, so the wheel past a column's end, or "Läs nästa"
moving a card into view, scrolled the whole page and hid the header.
Columns are now the containing block of what's in them, and the shell
clips. A spec checks this in Chromium and in WebKit at desktop size.

Closes #215
Closes #216

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Steady the reading reference image
All checks were successful
ci / check (push) Successful in 7m50s
ci / desktop (push) Successful in 16m37s
ci / e2e (push) Successful in 30m14s
e9218808b0
Android's "reading a post" failed in CI on this branch and iPhone's
locally, on parts that vary by timing: cards turning read after a second
on screen (#180), and masks, which Playwright draws over everything, so a
masked card head below the fold showed through the phone's tab bar when
that card had loaded. The visual spec now keeps cards as they are and
hides times and card heads with CSS, which the column clips. 60 of 60
repeated runs passed across the three profiles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
littlefox referenced this pull request from a commit 2026-10-21 18:55:55 +00:00
Sign in to join this conversation.
No description provided.