Every new post anywhere is downloaded in full, pictures included #240

New issue

Closed

opened 2026-10-21 19:22:21 +00:00 by littlefox · 1 comment

littlefox commented

2026-10-21 19:22:21 +00:00

Owner

Found in the performance review (#230, D-058).

events.rs notify_new_text runs for every new text in every conference we are a member of. For each one it fetches:

the text stat;
the mute check;
a full kom.preview: the whole body, pictures included, plus a get-text-stat for every link and name lookups;
the stat of every parent.

The preview is fetched before checking whether any notification kind is turned on, because "Nämner dig" (#217) needs to know about mentions. So on a busy server, every post in every channel you are in is downloaded in full as it is written, whether or not you will ever read it, and whatever the notification settings.

Directions:

Mentions: look for <person N: or the person's name in the body only (kom.body), without building a view.
Pictures: for a text whose content type is a picture, don't fetch the body at all.
Passive memberships: skip them; they are already skipped for unread.
Rate: cap how many of these run at once, so a burst of posts (for example an importer) doesn't queue hundreds of fetches in front of what the user is reading.

Found in the performance review (#230, D-058). `events.rs` `notify_new_text` runs for every new text in every conference we are a member of. For each one it fetches: - the text stat; - the mute check; - a full `kom.preview`: the whole body, **pictures included**, plus a `get-text-stat` for every link and name lookups; - the stat of every parent. The preview is fetched before checking whether any notification kind is turned on, because "Nämner dig" (#217) needs to know about mentions. So on a busy server, every post in every channel you are in is downloaded in full as it is written, whether or not you will ever read it, and whatever the notification settings. Directions: - **Mentions:** look for `<person N:` or the person's name in the body only (`kom.body`), without building a view. - **Pictures:** for a text whose content type is a picture, don't fetch the body at all. - **Passive memberships:** skip them; they are already skipped for unread. - **Rate:** cap how many of these run at once, so a burst of posts (for example an importer) doesn't queue hundreds of fetches in front of what the user is reading.

littlefox added this to the 0.6: Performance milestone

2026-10-21 19:22:21 +00:00

littlefox added the

area/protocol

kind/bug

labels

2026-10-21 19:22:21 +00:00

littlefox referenced this issue from a pull request that will close it,

2026-10-22 01:23:55 +00:00

New posts: look closer only at those that concern me, one at a time #260

littlefox closed this issue

2026-10-22 01:53:58 +00:00

littlefox referenced this issue from a commit

2026-10-22 01:54:00 +00:00

New posts: look closer only at those that concern me, one at a time

littlefox commented

2026-10-22 02:26:35 +00:00

Author

Owner

Merged in #260; main run #429 green. Verified: notifications, mentions, messages, side-column, presence and inbox specs on three profiles; tools/perf.sh with a burst of 20 new posts (10 pictures) from another session: server calls 97 → 19, main-thread time 0.22 → 0.05 s.

Merged in #260; main run #429 green. Verified: notifications, mentions, messages, side-column, presence and inbox specs on three profiles; `tools/perf.sh` with a burst of 20 new posts (10 pictures) from another session: server calls 97 → 19, main-thread time 0.22 → 0.05 s.