Footnotes drawn as part of their post (#277) #299

Merged
littlefox merged 6 commits from issue-277-footnotes into main 2026-10-22 22:49:47 +00:00
Owner

Closes #277

A footnote (the author's own addition to a post, D-061) is drawn as part of its post, not as a reply:

  • under the post's body, above reactions and actions: a thin rule, smaller text, "Fotnot" (numbered when several), its time, "Ny" while unread — in the single post, the thread's cards, the chat and the channel view;
  • not counted as a reply anywhere (thread nodes, the thread index behind the thread list, the channel view's "N svar"); never cut by the thread cap; a comment to a footnote is drawn as a reply to its post;
  • reading: in the modern look a post's footnotes are read with it. A footnote added later marks its post (card drawn whole, footnote "Ny") and is read by being seen, or reached in the reading order — which shows its post with the footnote highlighted. The classic look keeps elisp's order, same drawing;
  • channel view: a footnote that is itself a post there is drawn as a footnote with "Till inlägg N".

Verified: new e2e/tests/footnotes.spec.ts on a seeded "Fotnoter" channel (thread, channel view, chat) in desktop/android/iphone; thread/commands/compose specs updated to the new behaviour, phone reading snapshots updated; full e2e suite run (the only failures were those three, now passing); unit tests (layout with footnotes); lint with CI's three clippy commands; screenshots looked at.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #277 A footnote (the author's own addition to a post, D-061) is drawn as part of its post, not as a reply: - under the post's body, above reactions and actions: a thin rule, smaller text, "Fotnot" (numbered when several), its time, "Ny" while unread — in the single post, the thread's cards, the chat and the channel view; - not counted as a reply anywhere (thread nodes, the thread index behind the thread list, the channel view's "N svar"); never cut by the thread cap; a comment to a footnote is drawn as a reply to its post; - reading: in the modern look a post's footnotes are read with it. A footnote added later marks its post (card drawn whole, footnote "Ny") and is read by being seen, or reached in the reading order — which shows its post with the footnote highlighted. The classic look keeps elisp's order, same drawing; - channel view: a footnote that is itself a post there is drawn as a footnote with "Till inlägg N". Verified: new `e2e/tests/footnotes.spec.ts` on a seeded "Fotnoter" channel (thread, channel view, chat) in desktop/android/iphone; thread/commands/compose specs updated to the new behaviour, phone reading snapshots updated; full e2e suite run (the only failures were those three, now passing); unit tests (layout with footnotes); lint with CI's three clippy commands; screenshots looked at. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
A footnote is the author's own addition to a post, but it was drawn as
a reply card and counted as one, so it couldn't be told from a reply
(D-061). Now it sits under the post's body, in the single post, the
thread's cards, the chat and the channel view, and isn't counted as a
reply anywhere. In the modern look it is read with its post; one added
later shows its post, highlighted.

Refs #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Refs #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Reading or writing a footnote shows its post with the footnote
highlighted (#277), so the review order and the compose test look for
the highlighted footnote; the phone reading snapshots have the footnote
under the welcome post instead of a card below it.

Refs #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Roadmap: footnotes done
Some checks failed
ci / e2e (push) Has started running
ci / desktop (push) Has started running
ci / check (push) Failing after 11m11s
17df27e344
Refs #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Test: a footnote isn't counted among the root's replies
All checks were successful
ci / check (push) Successful in 10m59s
ci / desktop (push) Successful in 15m5s
ci / e2e (push) Successful in 32m53s
c0225f2e07
thread_tree counted the root's footnote as a reply; since #277 replies
are comments only.

Refs #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
littlefox referenced this pull request from a commit 2026-10-24 13:23:56 +00:00
Sign in to join this conversation.
No description provided.