Desktop: a server without a port gives "invalid socket address" #47
Labels
No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
littlefox/neokom#47
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
User report: typing
kom.lysator.liu.sein the server field and logging in fails with "invalid socket address". The desktop app (and kom-relay) pass the text straight to TcpStream::connect, which needs host:port. A bare host should get Protocol A's port 4894, and a bare IPv6 address its brackets.Also in #48, per the user: the desktop app's default server is now kom.lysator.liu.se (D-029). NEOKOM_SERVER still overrides it; the desktop smoke test sets it to its devserver.
Merged in #48 (CI run #78 green). Verified: unit tests for the address forms; new integration test bare_host_uses_default_port against the devserver by IP and by name; once, logged out, against kom.lysator.liu.se (plain after NotTls, GetTime ok). Desktop default server is kom.lysator.liu.se (D-029).