littlefox/neokom
Watch
1
2
Fork
You've already forked neokom
 1
Code Issues 8 Pull requests Projects Releases 12 Packages Activity Actions

Accept a server without a port (default 4894) #48

Merged
littlefox merged 2 commits from issue-47-default-port into main 2026-10-17 17:26:47 +00:00
Conversation 0 Commits 2 Files changed 7 +80 -7
littlefox commented 2026-10-17 17:11:42 +00:00
Owner
Copy link

Closes #47

A bare host gets port 4894 (bare IPv6 gets brackets) on the plain and TLS paths and for kom-relay. Unit tests for the address forms; integration test connecting by bare host. Checked once, logged out, against kom.lysator.liu.se.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #47 A bare host gets port 4894 (bare IPv6 gets brackets) on the plain and TLS paths and for kom-relay. Unit tests for the address forms; integration test connecting by bare host. Checked once, logged out, against kom.lysator.liu.se. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Accept a server without a port: default to Protocol A's 4894
Some checks are pending
ci / check (push) Has started running
Details
ci / e2e (push) Has started running
Details
ci / desktop (push) Has started running
Details
41c2828dfd 
Typing "kom.lysator.liu.se" on the desktop login page failed with
"invalid socket address": the text went straight to
TcpStream::connect, which wants host:port. with_default_port adds
4894 to a bare host (and brackets to a bare IPv6 address) on the
plain and TLS paths, and for kom-relay's target.

Verified with a new integration test (bare host against the
devserver, by IP and by name) and once, logged out, against
kom.lysator.liu.se.

Refs #47

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Desktop: default to kom.lysator.liu.se (D-029)
All checks were successful
ci / check (push) Successful in 6m45s
Details
ci / desktop (push) Successful in 11m58s
Details
ci / e2e (push) Successful in 12m40s
Details
441a123085 
The packaged app started with 127.0.0.1:4894, a development address.
It now starts with Lysator's server; NEOKOM_SERVER still overrides it,
and every test and script sets it to a devserver.

Refs #47

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/ci
Forgejo Actions, runner, tests

  
area/desktop
Desktop build

  
area/packaging
Arch, Debian, Fedora, NixOS packages

  
area/protocol
kom-proto, wire format, charset

  
area/reading
Unread tracking, reading order, review

  
area/ui
Dioxus app, layout, interaction

  
area/web
Web build and relay

  
area/writing
Composing and sending texts

  
kind/bug
Something is broken

  
kind/feature
New functionality

  
kind/infra
Tooling, tests, CI, dev environment

  
kind/request
requests for features or changes from users

  
needs/user
Waiting for a decision or action from littlefox

  
parked
Kept for reference; no work planned until the user says so

  
perf
Run the perf workflow and its budgets on this pull request (#287)

  
security
Security-relevant

  
upstream
A proposal for Protocol A or lyskomd, for the LysKOM development group

No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
littlefox/neokom!48
No description provided.