Stop baking MazeMap markers that have no text #22
Labels
No labels
animation
audio
blocked
bug report
controversial
documentation
easy
feature request
hard
medium
multiplayer
physics
ui
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
elsie/liuverse#22
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
369 of the 793
genericPOIs have notitle, andpoi_label(mazemap.rs:330) falls back toidentifier, which they mostly donot have either -- so they end up as an empty
BakedMarker.They cost bytes in
assets/baked/valla.bin, and they cost more than that: thewhole bake now has 13.5k+ markers (7.3k POIs plus the tile
markerslayer) andhud::poi_labelswalks all of them every frame to find the ten metres'worth that are close enough to draw.
interiors.rs:305already dedupes the tilelayer against the POI dump; the same dedupe should drop markers whose text is
empty, because nothing can ever draw them --
marker_trisskips empty text andpush_signdrops it again.Worth doing before any new marker kind is added, since it makes the per-frame
scan cheaper for everything downstream.
The related classification work -- turning those 793 generics into outdoor
signs, AEDs, bus stops and notice boards -- is #23.
Related