Studenthuset's sail still needs work #72
Labels
No labels
animation
audio
blocked
bug report
controversial
documentation
easy
feature request
hard
medium
multiplayer
physics
ui
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
elsie/liuverse#72
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to #13. The hand-authored sail added in
liuverse-fetch-map/src/landmarks.rsgives Studenthuset a mono-pitch roof, but it still does not match the real building closely enough.Current approximation:
RoofForm::Skillion, 8 m rise, high along the north facade and low south.What still looks wrong:
Where:
liuverse-fetch-map/src/landmarks.rs(shape values),liuverse-scene/src/roof.rs(roof geometry),liuverse-render/src/scene.rs(material split if the roof plane and walls need different colours).References: White Arkitekter project photos, Lantmäteriet orthophoto, Wikimedia Commons.
Context update: the sail this follows now exists in
2d7ddc5on the localroof-shapes-coloursbranch (liuverse-fetch-map/src/landmarks.rs+liuverse-scene/src/roof.rs), not onmainyet. It gives Studenthuset a mono-pitch sail; this issue’s points about the cantilever, glazed base and solar-panel roof plane still stand. Keep it as the follow-up and land it after #13/#14 merge.The sail is on main. The overhang is not.
The sail landed with the tagged roof shapes (
09f44f3, PR #75):liuverse-fetch-map/src/landmarks.rsgives Studenthuset aRoofForm::Skillionwith an explicit down-slope, so the mono-pitch and its high edge are in the world, and #13 and #14 are closed.The points this issue raised still stand: the real upper mass is a wedge cantilevered over a recessed glass ground floor and the game still draws one straight extrusion, so the overhang and the glazed base are missing; the roof plane is drawn in the facade red with no separate solar-panel field, and nothing in
liuverse-scene/src/roof.rsknows about panels; and the rise is still a photo-derived estimate that has not been checked against a section or a measured elevation.