Give roofs their actual shapes #13
Labels
No labels
animation
audio
blocked
bug report
controversial
documentation
easy
feature request
hard
medium
multiplayer
physics
ui
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
elsie/liuverse#13
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Every roof in the world is a flat cap:
mesh::roof_trisfans thefootprint at
collision::building_roof_height, and the shell has no roof form atall. The extract has 329
roof:shapetags:86 gabled and 40 skillion roofs are currently drawn as flat lids, which is most
of the visible silhouette of every OSM shell outside the MazeMap footprints.
roof:shapeplus the footprint's longest edge gives the ridge direction andform;
roof:height(14 ways, mostly 5 and 2) gives the rise, and falls back toa fraction of the footprint's short side when absent.
MazeMap buildings have no
roof:shapeand keep their flat cap -- only the OSMshells this touches.
Needs a decision about collision: a gabled roof is not a walkable surface. The
flat cap should stay as the collision surface and the gable drawn over it, rather
than making the walker climb.
Related
Roof shapes are the biggest silhouette win per line of code in the list. Using the footprint's longest edge for the ridge, falling back to a fraction of the short side, and keeping the flat cap as collision is the right set of compromises. Pair it with #14 since they parse the same tags.
Implemented in
2d7ddc5onroof-shapes-colours(not yet merged tomain):roof:shape,roof:heightandroof:directionare parsed and gabled, skillion, hipped, gambrel and saltbox roofs are drawn over the flat collision cap.