littlefox/neokom
Watch
1
2
Fork
You've already forked neokom
 1
Code Issues 9 Pull requests 1 Projects Releases 12 Packages Activity Actions

Desktop notifications: keep the D-Bus connection open #191

Merged
littlefox merged 1 commit from issue-182-desktop-notifications into main 2026-10-20 12:01:49 +00:00
Conversation 0 Commits 1 Files changed 4 +117 -3
littlefox commented 2026-10-20 11:31:16 +00:00
Owner
Copy link

Cinnamon/GNOME Shell drop an app's notifications when the sending connection closes; we closed it after every notification. One long-lived connection now, plus the desktop-entry hint. Regression test with a fake notification service on a private dbus-daemon (fails without the fix); CI runs desktop unit tests.

Closes #182

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Cinnamon/GNOME Shell drop an app's notifications when the sending connection closes; we closed it after every notification. One long-lived connection now, plus the desktop-entry hint. Regression test with a fake notification service on a private dbus-daemon (fails without the fix); CI runs desktop unit tests. Closes #182 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Keep the notification connection open on the desktop
All checks were successful
ci / check (push) Successful in 9m19s
Details
packaging / arch (pull_request) Successful in 11m46s
Details
ci / desktop (push) Successful in 15m41s
Details
packaging / nix (pull_request) Successful in 21m15s
Details
packaging / debian (pull_request) Successful in 22m36s
Details
packaging / fedora (pull_request) Successful in 26m35s
Details
packaging / release (pull_request) Has been skipped
Details
ci / e2e (push) Successful in 30m15s
Details
de4cbcdd5d 
Cinnamon and GNOME Shell withdraw an app's notifications as soon as
the D-Bus connection that sent them closes. NeoKOM opened a connection
per notification and dropped it right after, so the desktop accepted
each one (the test button said "Sent") and removed it at once. Keep one
connection for the app's lifetime, and name the desktop entry so the
notification shows NeoKOM's name and icon. A test plays Cinnamon's part
on a private bus; CI now runs the desktop unit tests.

Closes #182

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
littlefox referenced this pull request from a commit 2026-10-21 18:55:54 +00:00
Release 0.5.0
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/ci
Forgejo Actions, runner, tests

  
area/desktop
Desktop build

  
area/packaging
Arch, Debian, Fedora, NixOS packages

  
area/protocol
kom-proto, wire format, charset

  
area/reading
Unread tracking, reading order, review

  
area/ui
Dioxus app, layout, interaction

  
area/web
Web build and relay

  
area/writing
Composing and sending texts

  
kind/bug
Something is broken

  
kind/feature
New functionality

  
kind/infra
Tooling, tests, CI, dev environment

  
kind/request
requests for features or changes from users

  
needs/user
Waiting for a decision or action from littlefox

  
parked
Kept for reference; no work planned until the user says so

  
perf
Run the perf workflow and its budgets on this pull request (#287)

  
security
Security-relevant

  
upstream
A proposal for Protocol A or lyskomd, for the LysKOM development group

No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
littlefox/neokom!191
No description provided.