Phone: the settings screen is wider than the screen #246
Labels
No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
littlefox/neokom#246
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found while adding the version line (#245). On iPhone (390 px) and Android (412 px),
section.settings-screenhas ascrollWidthof 686/680 px: every section is stretched to that width, so the screen scrolls sideways and the text runs off the right edge.Cause:
.settingsis a grid with an automatic column, and a grid column is at least as wide as its widest item's min-content. The longselects ("Latin-1 när det går, annars UTF-8", the reading-order choice) set that width.Fix:
grid-template-columns: minmax(0, 1fr)andmax-width: 100%on the selects; a spec checks there is no sideways scroll on phones.Merged in #247; main run #401 green. Verified:
settings.specnow checks that the settings screen does not scroll sideways (scrollWidth ≤ clientWidth) on all three profiles; iPhone screenshots looked at.