Settings say "Sparat." while a change is still waiting to be saved #294

New issue

Closed

opened 2026-10-22 14:46:30 +00:00 by littlefox · 1 comment

littlefox commented

2026-10-22 14:46:30 +00:00

Owner

Found when release PR #281's CI failed (run #472) in notifications.spec.ts: a notification was shown during quiet hours.

Cause: settings are saved a second after the last change (settings_view.rs, changed), but the label keeps the previous state meanwhile. So "Sparat." from an earlier save stays up while newer changes haven't been written. The test waited for "Sparat.", went back, and the message arrived before the quiet hours were saved. A person who sees "Sparat." and closes the app straight away is told the same thing.

Fix: "Sparar…" from the first change on, and "Sparat." only when the newest change has been written.

Found when release PR #281's CI failed (run #472) in notifications.spec.ts: a notification was shown during quiet hours. Cause: settings are saved a second after the last change (`settings_view.rs`, `changed`), but the label keeps the previous state meanwhile. So "Sparat." from an earlier save stays up while newer changes haven't been written. The test waited for "Sparat.", went back, and the message arrived before the quiet hours were saved. A person who sees "Sparat." and closes the app straight away is told the same thing. Fix: "Sparar…" from the first change on, and "Sparat." only when the newest change has been written.

littlefox added this to the 0.6: Performance milestone

2026-10-22 14:46:30 +00:00

littlefox added the

kind/bug

area/ui

labels

2026-10-22 14:46:30 +00:00

littlefox referenced this issue from a pull request that will close it,

2026-10-22 14:52:26 +00:00

Settings: "Sparar…" until the newest change is written #295

littlefox referenced this issue from a commit

2026-10-22 14:52:28 +00:00

Settings: "Sparar…" until the newest change is written

littlefox closed this issue

2026-10-22 15:25:29 +00:00

littlefox commented

2026-10-22 15:57:23 +00:00

Author

Owner

Fixed in #295: "Sparar…" shows from the first change, and "Sparat." only once the newest change is written. Verified: settings.spec.ts now changes a setting after "Sparat." and expects "Sparar…" within 0.5 s, then "Sparat.". settings and notifications specs passed locally on desktop, Android and iPhone; PR CI and main #476 green.