Links to a post, in the web and the desktop app (#289) #304

Merged

littlefox merged 8 commits from issue-289-links into main 2026-10-23 15:45:17 +00:00

Conversation 0 Commits 8 Files changed 22 +771 -20

littlefox commented 2026-10-23 01:34:48 +00:00

Owner

Copy link

Closes #289

Links to a post that open in NeoKOM, in the browser and the desktop app (the plan on #289):

1. kom_client::link: parse and format <server>/<kind>/<N> as a web link (https://…/#server/text/N), lyskom://server/text/N or bare, and <text N: Ämne>; the server is its canonical-name (aux 31; kom.lysator.liu.se sets it, a logged-out probe), else the address logged in to. Unit tests incl. random input.
2. Copy and open: "Kopiera länk" in a post's ··· menu; opening from Ctrl+K and the channel/post field; a link for another server says so; a missing or unreadable post gets the same message; a link pasted into the composer becomes <text N: Ämne>; the post opens in its thread, briefly highlighted, not read.
3. Web: the link after # (the server never sees it), kept through the login page, cleared once opened; hashchange opens new ones.
4. Desktop: neokom.desktop handles x-scheme-handler/lyskom (Exec=neokom %u); one app at a time — a second launch hands its link over a socket in $XDG_RUNTIME_DIR and exits; NeoKOM links inside posts open in the app.

The devserver now sets canonical-name (dev.neokom.test).

Verified: new e2e/tests/share-links.spec.ts (logged out → log in → post shown and highlighted; address change; another server; unreadable post; Ctrl+K; copy; pasted link → reference) in desktop/android/iphone; full e2e suite 377 passed; desktop smoke test with a second neokom lyskom://… handing over (one session, the post shown); lint with CI's three clippy commands; unit tests; screenshots looked at.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #289 Links to a post that open in NeoKOM, in the browser and the desktop app (the plan on #289): 1. **`kom_client::link`**: parse and format `<server>/<kind>/<N>` as a web link (`https://…/#server/text/N`), `lyskom://server/text/N` or bare, and `<text N: Ämne>`; the server is its `canonical-name` (aux 31; kom.lysator.liu.se sets it, a logged-out probe), else the address logged in to. Unit tests incl. random input. 2. **Copy and open**: "Kopiera länk" in a post's ··· menu; opening from Ctrl+K and the channel/post field; a link for another server says so; a missing or unreadable post gets the same message; a link pasted into the composer becomes `<text N: Ämne>`; the post opens in its thread, briefly highlighted, not read. 3. **Web**: the link after `#` (the server never sees it), kept through the login page, cleared once opened; `hashchange` opens new ones. 4. **Desktop**: `neokom.desktop` handles `x-scheme-handler/lyskom` (`Exec=neokom %u`); one app at a time — a second launch hands its link over a socket in `$XDG_RUNTIME_DIR` and exits; NeoKOM links inside posts open in the app. The devserver now sets canonical-name (`dev.neokom.test`). Verified: new `e2e/tests/share-links.spec.ts` (logged out → log in → post shown and highlighted; address change; another server; unreadable post; Ctrl+K; copy; pasted link → reference) in desktop/android/iphone; full e2e suite 377 passed; desktop smoke test with a second `neokom lyskom://…` handing over (one session, the post shown); lint with CI's three clippy commands; unit tests; screenshots looked at. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

littlefox added 4 commits 2026-10-23 01:34:48 +00:00

Links to a post: copy one, open one (#289, steps 1-3) ... b1f401d42a

"Kopiera länk" gives a link that opens the post in NeoKOM for anyone
who can read it: the server's canonical-name and the post's number after
the page's #, so the web server never sees it. Links open from the
address (kept through the login), from Ctrl+K and from the post field;
one for another server says so, and a pasted link becomes <text N: …>
in a post. kom.lysator.liu.se sets canonical-name (a logged-out probe);
the devserver now does too. The desktop lyskom:// handler is step 4.

Refs #289

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Links: lyskom:// opens the desktop app, one app at a time (#289, step 4) ... c25a3e5f1d

neokom.desktop registers x-scheme-handler/lyskom, so the OS runs
neokom with the link. If NeoKOM is already running, the new launch
hands the link over a socket in XDG_RUNTIME_DIR and exits: one login,
not two. A NeoKOM link inside a post opens in the app too, not in a
new browser tab. The desktop smoke test checks the hand-over.

Closes #289

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Merge main into issue-289-links 2128b51c7d

Roadmap: links done ... cac67514d9

Refs #289

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

littlefox added 1 commit 2026-10-23 02:15:31 +00:00

Test: open an ordinary post by link, not a footnote ... 746ab1a597

Post 58 is the footnote to 57, so since #277 it opens as 57 with the
footnote highlighted; whether the head showed 57 or 58 depended on
timing (failed once on CI, iPhone). 59 is a comment.

Refs #289

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

littlefox added 1 commit 2026-10-23 10:07:55 +00:00

Merge main into issue-289-links c9e768ff84

littlefox added 1 commit 2026-10-23 11:50:43 +00:00

Merge remote-tracking branch 'origin/main' into issue-289-links ... 85e02a3656

# Conflicts:
#	app/src/i18n.rs
#	app/src/main.rs
#	docs/DESIGN.md
#	docs/ROADMAP.md

littlefox added 1 commit 2026-10-23 14:05:43 +00:00

Merge remote-tracking branch 'origin/main' into issue-289-links ... 44ac09abc3

# Conflicts:
#	app/src/i18n.rs
#	app/src/main.rs

littlefox merged commit 7752ce22aa into main 2026-10-23 15:45:17 +00:00

littlefox referenced this pull request from a commit 2026-10-23 15:45:19 +00:00

Merge pull request 'Links to a post, in the web and the desktop app (#289)' (#304) from issue-289-links into main

littlefox referenced this pull request 2026-10-23 16:21:47 +00:00

Links to a post or thread that open in the web and the desktop app #289

littlefox referenced this pull request 2026-10-24 13:23:54 +00:00

Release 0.7.0 #328

littlefox referenced this pull request from a commit 2026-10-24 13:23:56 +00:00

Release 0.7.0

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/ci

Forgejo Actions, runner, tests

  

area/desktop

Desktop build

  

area/packaging

Arch, Debian, Fedora, NixOS packages

  

area/protocol

kom-proto, wire format, charset

  

area/reading

Unread tracking, reading order, review

  

area/ui

Dioxus app, layout, interaction

  

area/web

Web build and relay

  

area/writing

Composing and sending texts

  

kind/bug

Something is broken

  

kind/feature

New functionality

  

kind/infra

Tooling, tests, CI, dev environment

  

kind/request

requests for features or changes from users

  

needs/user

Waiting for a decision or action from littlefox

  

parked

Kept for reference; no work planned until the user says so

  

perf

Run the perf workflow and its budgets on this pull request (#287)

  

security

Security-relevant

  

upstream

A proposal for Protocol A or lyskomd, for the LysKOM development group

No labels

area/ci

area/desktop

area/packaging

area/protocol

area/reading

area/ui

area/web

area/writing

kind/bug

kind/feature

kind/infra

kind/request

needs/user

parked

perf

security

upstream

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

littlefox/neokom!304

No description provided.