littlefox/neokom
Watch
1
2
Fork
You've already forked neokom
 1
Code Issues 8 Pull requests Projects Releases 12 Packages Activity Actions

Settings: re-read the user area before changing it #383

Merged
littlefox merged 1 commit from issue-332-user-area into main 2026-10-28 10:11:30 +00:00
Conversation 0 Commits 1 Files changed 8 +171 -72
littlefox commented 2026-10-28 09:32:12 +00:00
Owner
Copy link

Closes #332

Option 1, as the user chose: every settings change reads the user area again and applies only that change (Kom::update_settings), so NeoKOM no longer undoes what another client wrote since login. Saves from one session take turns.

Verified: new devserver test user_area_changes_meet (two NeoKOM sessions with stale copies, plus an Emacs-style write of elisp/common in between: all three changes survive); all 33 devserver tests pass; clippy three ways.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #332 Option 1, as the user chose: every settings change reads the user area again and applies only that change (`Kom::update_settings`), so NeoKOM no longer undoes what another client wrote since login. Saves from one session take turns. Verified: new devserver test `user_area_changes_meet` (two NeoKOM sessions with stale copies, plus an Emacs-style write of `elisp`/`common` in between: all three changes survive); all 33 devserver tests pass; clippy three ways. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Settings: re-read the user area before changing it
All checks were successful
perf / perf (pull_request) Has been skipped
Details
ci / plan (push) Successful in 1m52s
Details
ci / check (push) Successful in 9m6s
Details
ci / desktop (push) Successful in 17m26s
Details
ci / e2e (android) (push) Successful in 19m34s
Details
ci / e2e (iphone) (push) Successful in 21m15s
Details
ci / e2e (desktop) (push) Successful in 22m38s
Details
f3abfa221f 
The user area was written from the copy read at login, so anything
another client changed in between (Emacs, NeoKOM on another device) was
undone by NeoKOM's next save, however small. update_settings now reads
it again and applies only the change being made; saves from one session
take turns.

Refs #332

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
littlefox referenced this pull request from a commit 2026-10-28 15:15:37 +00:00
Release 0.8.0
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/ci
Forgejo Actions, runner, tests

  
area/desktop
Desktop build

  
area/packaging
Arch, Debian, Fedora, NixOS packages

  
area/protocol
kom-proto, wire format, charset

  
area/reading
Unread tracking, reading order, review

  
area/ui
Dioxus app, layout, interaction

  
area/web
Web build and relay

  
area/writing
Composing and sending texts

  
kind/bug
Something is broken

  
kind/feature
New functionality

  
kind/infra
Tooling, tests, CI, dev environment

  
kind/request
requests for features or changes from users

  
needs/user
Waiting for a decision or action from littlefox

  
parked
Kept for reference; no work planned until the user says so

  
perf
Run the perf workflow and its budgets on this pull request (#287)

  
security
Security-relevant

  
upstream
A proposal for Protocol A or lyskomd, for the LysKOM development group

No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
littlefox/neokom!383
No description provided.