Start each newly shown text at the top #74

Merged

littlefox merged 7 commits from issue-73-scroll-top into main 2026-10-17 19:52:01 +00:00

Conversation 0 Commits 7 Files changed 8 +555 -339

littlefox commented 2026-10-17 18:25:34 +00:00

Owner

Copy link

Closes #73

Built on #63 (the main_view split); merge that first.

Scrolls main.reading to the top whenever a different text, conference status or pane is shown; same-text refreshes keep the place. New e2e scroll.spec.ts fails without the fix (272 px instead of 0); suite 35/35 locally.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #73 Built on #63 (the main_view split); merge that first. Scrolls main.reading to the top whenever a different text, conference status or pane is shown; same-text refreshes keep the place. New e2e scroll.spec.ts fails without the fix (272 px instead of 0); suite 35/35 locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

littlefox added 4 commits 2026-10-17 18:25:34 +00:00

Split main_view.rs into components ... 2a8c096519

main_view.rs was one 730-line component. The top bar, the conference
column, the side panel and the reader's banners and command bar are
now their own components under app/src/main_view/, each keeping its
own form state. mod.rs keeps the reading state and the actions. No
behaviour change; 0.2's phone layout, palette and tour build on this.

Refs #49

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

i18n test: scan subdirectories of src/ ... c6fa4faf57

every_key_is_translated read src/ flat and failed on the new
main_view/ directory ("Is a directory"). It now walks the tree, and
asserts that it found main_view/conf_nav.rs so a future layout change
can't silently skip files.

Refs #49

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Merge remote-tracking branch 'origin/main' into issue-49-split-views d24a36589c

Start each newly shown text at the top of the reading column ... a458ec2bdc

The reading column scrolls on its own and kept its position when the
next text replaced a long one. Chromium clamps it to the shorter
content; WebKitGTK can leave it past the end with no scrollbar, so the
user saw half a text or nothing. Scroll to the top whenever a
different text, conference status or pane is shown; refreshes of the
same text (mark, fast reply, confirmation) keep the place.

scroll.spec.ts fails without the fix (272 px down instead of 0).

Refs #73

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

littlefox referenced this pull request 2026-10-17 18:35:21 +00:00

Bump to 0.1.2 #75

littlefox added 3 commits 2026-10-17 19:28:25 +00:00

Re-run CI (run #92: runner lost its Docker socket after the tests passed) ... c714ff2386

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Merge remote-tracking branch 'origin/main' into issue-49-split-views 1e60859b23

Merge remote-tracking branch 'origin/issue-49-split-views' into issue-73-scroll-top 7c2806da5a

littlefox merged commit 7705bff9a5 into main 2026-10-17 19:52:01 +00:00

littlefox referenced this pull request from a commit 2026-10-17 19:52:01 +00:00

Merge pull request 'Start each newly shown text at the top' (#74) from issue-73-scroll-top into main

littlefox referenced this pull request 2026-10-17 19:53:01 +00:00

Reader keeps the old scroll position when the next text is shown #73

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/ci

Forgejo Actions, runner, tests

  

area/desktop

Desktop build

  

area/packaging

Arch, Debian, Fedora, NixOS packages

  

area/protocol

kom-proto, wire format, charset

  

area/reading

Unread tracking, reading order, review

  

area/ui

Dioxus app, layout, interaction

  

area/web

Web build and relay

  

area/writing

Composing and sending texts

  

kind/bug

Something is broken

  

kind/feature

New functionality

  

kind/infra

Tooling, tests, CI, dev environment

  

kind/request

requests for features or changes from users

  

needs/user

Waiting for a decision or action from littlefox

  

parked

Kept for reference; no work planned until the user says so

  

perf

Run the perf workflow and its budgets on this pull request (#287)

  

security

Security-relevant

  

upstream

A proposal for Protocol A or lyskomd, for the LysKOM development group

No labels

area/ci

area/desktop

area/packaging

area/protocol

area/reading

area/ui

area/web

area/writing

kind/bug

kind/feature

kind/infra

kind/request

needs/user

parked

perf

security

upstream

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

littlefox/neokom!74

No description provided.