littlefox/neokom
Watch
1
2
Fork
You've already forked neokom
 1
Code Issues 8 Pull requests Projects Releases 12 Packages Activity Actions

Split main_view.rs into components #63

Merged
littlefox merged 5 commits from issue-49-split-views into main 2026-10-17 19:51:59 +00:00
Conversation 0 Commits 5 Files changed 7 +486 -339
littlefox commented 2026-10-17 17:42:30 +00:00
Owner
Copy link

Closes #49

main_view.rs (730 lines, one component) becomes app/src/main_view/ with top_bar, conf_nav, reader and side_panel components; mod.rs keeps the reading state and actions. No behaviour change: e2e 33/33 locally. DESIGN.md §1 describes the parts.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8

Closes #49 main_view.rs (730 lines, one component) becomes app/src/main_view/ with top_bar, conf_nav, reader and side_panel components; mod.rs keeps the reading state and actions. No behaviour change: e2e 33/33 locally. DESIGN.md §1 describes the parts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Split main_view.rs into components
Some checks failed
ci / check (push) Failing after 5m0s
Details
ci / desktop (push) Successful in 13m58s
Details
ci / e2e (push) Successful in 15m30s
Details
2a8c096519 
main_view.rs was one 730-line component. The top bar, the conference
column, the side panel and the reader's banners and command bar are
now their own components under app/src/main_view/, each keeping its
own form state. mod.rs keeps the reading state and the actions. No
behaviour change; 0.2's phone layout, palette and tour build on this.

Refs #49

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
every_key_is_translated read src/ flat and failed on the new
main_view/ directory ("Is a directory"). It now walks the tree, and
asserts that it found main_view/conf_nav.rs so a future layout change
can't silently skip files.

Refs #49

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Merge remote-tracking branch 'origin/main' into issue-49-split-views
Some checks failed
packaging / release (push) Has been skipped
Details
packaging / nix (push) Successful in 34m19s
Details
ci / check (push) Failing after 6m24s
Details
ci / e2e (push) Successful in 13m21s
Details
ci / desktop (push) Successful in 14m58s
Details
packaging / arch (push) Successful in 12m59s
Details
packaging / debian (push) Successful in 25m49s
Details
packaging / fedora (push) Successful in 26m16s
Details
d24a36589c
Re-run CI (run #92: runner lost its Docker socket after the tests passed)
Some checks failed
ci / check (push) Failing after 9m15s
Details
ci / desktop (push) Successful in 12m38s
Details
ci / e2e (push) Successful in 18m30s
Details
c714ff2386 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XJW2ocwLunyaLiUwCBHEP8
Merge remote-tracking branch 'origin/main' into issue-49-split-views
All checks were successful
ci / check (push) Successful in 7m15s
Details
ci / desktop (push) Successful in 13m42s
Details
ci / e2e (push) Successful in 19m11s
Details
1e60859b23
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/ci
Forgejo Actions, runner, tests

  
area/desktop
Desktop build

  
area/packaging
Arch, Debian, Fedora, NixOS packages

  
area/protocol
kom-proto, wire format, charset

  
area/reading
Unread tracking, reading order, review

  
area/ui
Dioxus app, layout, interaction

  
area/web
Web build and relay

  
area/writing
Composing and sending texts

  
kind/bug
Something is broken

  
kind/feature
New functionality

  
kind/infra
Tooling, tests, CI, dev environment

  
kind/request
requests for features or changes from users

  
needs/user
Waiting for a decision or action from littlefox

  
parked
Kept for reference; no work planned until the user says so

  
perf
Run the perf workflow and its budgets on this pull request (#287)

  
security
Security-relevant

  
upstream
A proposal for Protocol A or lyskomd, for the LysKOM development group

No labels
area/ci
area/desktop
area/packaging
area/protocol
area/reading
area/ui
area/web
area/writing
kind/bug
kind/feature
kind/infra
kind/request
needs/user
parked
perf
security
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
littlefox/neokom!63
No description provided.